Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed broken Community Edit This Page link #1667

Closed
wants to merge 1 commit into from

Conversation

ThomasWT
Copy link
Contributor

@ThomasWT ThomasWT commented Sep 28, 2024

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

image

What was wrong?

The Edit this page link was broken and linked to a Github 404 page (ex https://github.com/nuxt/nuxt/edit/main/docs/1.getting-started/4.styling.md). This link also assumed you could edit the files directly and not through a fork.

What was the change/fix?

The Edit this page now links to the /blob/ (ex: https://github.com/nuxt/nuxt/blob/main/docs/1.getting-started/1.introduction.md) instead of the /edit/ and leaves it up to the user to fork and then edit.

@danielroe
Copy link
Member

linking this thread:

https://twitter.com/eoThica/status/1845567376362025040

@pntthomsen
Copy link

Closing this as it turns out it's a problem with my Github account.

github.account.mp4

@ThomasWT ThomasWT closed this Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants