This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
Add search folder by UID #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlclmj
suggested changes
Oct 17, 2019
Comment on lines
+40
to
+41
| ID int64 `json:"id"` | ||
| UID string `json:"uid"` |
Comment on lines
+46
to
+47
| FolderID int64 `json:"folderId"` | ||
| FolderUID string `json:"folderUid"` |
| Id int64 `json:"id"` | ||
| Uid string `json:"uid"` | ||
| ID int64 `json:"id"` | ||
| UID string `json:"uid"` |
There was a problem hiding this comment.
I don't think it's a great idea to be renaming these, as we tend to follow the Id and Uid convention for these fields. Would you be alright keeping these as-is?
| func (c *Client) DeleteDashboard(slug string) error { | ||
| path := fmt.Sprintf("/api/dashboards/db/%s", slug) | ||
| // DeleteDashboard deletes a grafana dashoboard | ||
| func (c *Client) DeleteDashboard(uid string) (string, error) { |
There was a problem hiding this comment.
Can we add a DeleteDashboardByUid function and mark the existing one as deprecated?
| @@ -31,6 +35,24 @@ type Dashboard struct { | |||
| Overwrite bool `json:overwrite` | |||
| } | |||
|
|
|||
| // Dashboards represent json returned by search API | |||
| type Dashboards struct { | |||
There was a problem hiding this comment.
If this is specific to the search endpoint can we name it something more along the lines of DashboardSearchResponse?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to search a folder in grafana by using UID