Don't set local close code when remote closes the connection #696
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems like some bots are experiencing random disconnections that nyxx is not considering as unexpected (which would cause a reconnect). This means the bot effectively goes offline, but is left in a limbo state where the client is still active.
Im not sure why the reconnect loop isn't triggering. This PR will be updated as I find more problems in the code; for now it only contains a fix the the
localCloseCode
being set even when Discord closes the connection (causing a race condition of sorts for detecting error close codes).Type of change
Checklist:
dart analyze
ormake analyze
and fixed all issuesdart format --set-exit-if-changed -l 160 ./lib
ormake format
and fixed all issues