Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #494

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Update README.md #494

merged 1 commit into from
Jul 13, 2023

Conversation

LucidSamuel
Copy link
Contributor

Think we should indicate the need to install docusaurus because npm run dev wouldn't work according to the code without doing so.

Think we should indicate the need to install docusaurus because npm run dev wouldn't work according to the code without doing so.
@LucidSamuel LucidSamuel requested a review from a team as a code owner July 12, 2023 21:54
@LucidSamuel LucidSamuel self-assigned this Jul 12, 2023
@vercel
Copy link

vercel bot commented Jul 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2023 9:54pm

Copy link
Contributor

@barriebyron barriebyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @LucidSamuel for this update!

@barriebyron barriebyron merged commit ea20689 into main Jul 13, 2023
@barriebyron barriebyron deleted the LucidSamuel-patch-1 branch July 13, 2023 18:17
@MartinMinkov
Copy link
Contributor

For what it's worth, I don't run into this issue at all :/ The CLI tool is only used for scaffolding the project, it shouldn't affect starting the dev server

@barriebyron
Copy link
Contributor

well, if we don't need users to install docusaurus, then let's not have them do it

Revert PR #497

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants