-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add snarkyjs-pack community package to README.md [now with provable tests and doc comments!] #1040
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exciting to see more community packages!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just making sure -- did someone review the library?
I just took a quick look. It would be good if the package could add an e2e integration test (demonstrating the functionality in a smart contract, or other provable code). Additionally, I couldn't find any doc comments (which would be a nice to have!) cc @45930 |
@Trivo25 yeah I will plan to do that after my cohort 1 presentation. I am busy working on that for the next couple weeks. |
@mitschabaude no one has reviewed thoroughly AFAIK |
That's fine! It's not a must, but would be great if you want to be listed as a community package in SnarkyJS :) |
@mitschabaude I see you approved, because I am uncertain about the technical status, would you be up for merging this PR when you feel the package meets the high quality package guidelines? Another option, we label it as experimental? |
I only approved to no longer be "requesting changes" 😅 I think the comment by Florian still makes sense, we want those packages to have a test |
Excited about our second package candidate. We'll leave this PR open as we await package updates from @45930 |
Hi guys. I added provable tests and doc comments, as well as rebranded everything to "o1js". https://github.com/45930/o1js-pack/blob/main/src/lib/PackingPlant.ts |
ready to merge, thank you @45930 for your contribution and community package I contributed 45930/o1js-pack#14 for your package README Consider me your friendly package editor! |
This PR adds our second community package for o1js to the README
https://discord.com/channels/484437221055922177/915745847692636181/1131617947534753962