Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it's impossible to use PHI/UNPHI programatically (outside of Mojos) #3383

Open
volodya-lombrozo opened this issue Sep 24, 2024 · 4 comments
Open

Comments

@volodya-lombrozo
Copy link
Member

Currently, in order to apply phi/unphi transformations I must call xmir-to-phi and phi-to-xmir goals. It's fine for most of the integration pipelines. However, I faced with the following problem: I need to use these transformations in one of my unit tests. And it's almost impossible to do.

What I suggest:

  1. Create Phi#unphi() and Xmir#toPhi() methods
  2. Use them in PhiMojo and UnphiMojo

Benefits:

  1. The ability to use these transformations programmatically, without the need to call xmir-to-phi and phi-to-xmir goals
  2. We will be able to test phi/unphi transformations through unit tests inside eo-maven-plugin (Now we use integration tests with FakeMaven)
  3. We will reduce coupling between internal components of PhiMojo and UnphiMojo and simplify them significantly
@volodya-lombrozo
Copy link
Member Author

@yegor256 @maxonfjvipon Could you take a look, please?

@volodya-lombrozo
Copy link
Member Author

Blocks objectionary/jeo-maven-plugin#720

@yegor256
Copy link
Member

@maxonfjvipon I think it's a good idea, let's do it?

@0crat
Copy link

0crat commented Sep 24, 2024

@volodya-lombrozo Hey there, bug hunter! 🐛 Great job spotting that new bug - you've just bagged yourself 8 points! It's awesome how you're helping us level up our project's quality. Keep your eyes peeled for anything else that doesn't quite hit the mark. Remember, we're always keen to hear about any issues you come across. Your keen eye has pushed your balance up to +101 points. Keep up the great work!

@yegor256 yegor256 changed the title PHI/UNPHI programatically without Mojo execution it's impossible to use PHI/UNPHI programatically (outside of Mojos) Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants