Unroll PHI/UNPHI Transformations #720
Conversation
|
Blocked by #715 |
|
Blocked by objectionary/eo#3383 |
…ir for assemble goal
| * @throws IOException If fails. | ||
| */ | ||
| private static XML parse(final String eoprog) throws IOException { | ||
| return new EoSyntax("name", new InputOf(eoprog)).parsed(); |
There was a problem hiding this comment.
@volodya-lombrozo I think this is the problem of objectionary/eo#3373 (comment)
There was a problem hiding this comment.
@maxonfjvipon Please, read this issue objectionary/eo#3380 it's a bug in eo
There was a problem hiding this comment.
@volodya-lombrozo I think the default constructor won't help you here because the name should taken from somewhere. Can't you set it manually from the file name?
There was a problem hiding this comment.
@maxonfjvipon Please, extend this issue with your knowledge about file names objectionary/eo#3380
|
@rultor merge |
@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here |
@volodya-lombrozo Done! FYI, the full log is here (took me 32min) |
|
@volodya-lombrozo Thanks for your contribution! Your effort is appreciated, but there's room for improvement. Here's the breakdown: +4 base points, -8 for 783 hits-of-code (exceeding 200), -16 for missing code review, and +24 to meet the minimum reward. Remember, our policy values quality over quantity. Aim for smaller, focused contributions and ensure code reviews for better rewards. Your current balance is +109. Keep refining your approach! |
In this PR I unroll all the changes made by
phi/unphitransformations.When these transformations are applied to the
xmirgenereated byjeo-maven-plugin, thexmirstructure is changed significantly.We apply this "back" transformations to make the
xmirundestandable byjeo-maven-pluginafterphi/unphitransformations.Related to #705.
PR-Codex overview
This PR primarily focuses on enhancing the
Bytecodehandling classes by adding@ToStringand@EqualsAndHashCodeannotations for better object representation and equality checks, along with updates to theUnrollMojoclass for handling PHI/UNPHI transformations.Detailed summary
@ToStringand@EqualsAndHashCodeannotations to:BytecodeHandlerBytecodeMethodBuilderBytecodeDefaultValueBytecodeInstructionEntryBytecodeClassandBytecodeMethodPropertiesto useListinstead ofCollection.UnrollMojoto include newunroll-phifunctionality.CanonicalXmirTestto verify bytecode integrity after transformations.