Merge pull request #749 from volodya-lombrozo/618_eo_printing

Enable EO Printing in 'bytecode-to-eo' IT
objectionary · Oct 9, 2024 · a21c963 · a21c963 · 0pdd · Oct 9, 2024
2 parents 23807e5 + 774925d
commit a21c963
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 30 deletions.
diff --git a/src/it/bytecode-to-eo/pom.xml b/src/it/bytecode-to-eo/pom.xml
@@ -67,47 +67,31 @@ SOFTWARE.
           </execution>
         </executions>
       </plugin>
-      <!--
-        @todo #610:30min Enable EO Printing in 'bytecode-to-eo' it.
-         The `print` goal is currently disabled because it doesn't
-         support Java 8. You can read more about it right here:
-         https://github.com/objectionary/eo/issues/3207
-         Once it is implemented, this comment should be removed and the goal
-         should be enabled. Don't forget to enable checks in `verify.groovy`
-         file related to `.eo` files. Now they are commented.
-      -->
-      <!--      <plugin>-->
-      <!--        <groupId>org.eolang</groupId>-->
-      <!--        <artifactId>eo-maven-plugin</artifactId>-->
-      <!--        <version>0.39.0</version>-->
-      <!--        <executions>-->
-      <!--          <execution>-->
-      <!--            <id>convert-xmir-to-eo</id>-->
-      <!--            <phase>process-classes</phase>-->
-      <!--            <goals>-->
-      <!--              <goal>print</goal>-->
-      <!--            </goals>-->
-      <!--            <configuration>-->
-      <!--              <printSourcesDir>${project.build.directory}/generated-sources/jeo-xmir</printSourcesDir>-->
-      <!--              <printOutputDir>${project.build.directory}/generated-sources/jeo-eo</printOutputDir>-->
-      <!--            </configuration>-->
-      <!--          </execution>-->
-      <!--        </executions>-->
-      <!--      </plugin>-->
       <plugin>
         <groupId>org.eolang</groupId>
         <artifactId>eo-maven-plugin</artifactId>
         <version>0.39.1</version>
         <executions>
           <execution>
-            <id>convert-xmir-to-eo</id>
+            <id>convert-xmir-to-phi</id>
             <phase>process-classes</phase>
             <goals>
               <goal>xmir-to-phi</goal>
             </goals>
             <configuration>
               <phiInputDir>${project.build.directory}/generated-sources/jeo-xmir</phiInputDir>
-              <phiOutputDir>${project.build.directory}/generated-sources/jeo-eo</phiOutputDir>
+              <phiOutputDir>${project.build.directory}/generated-sources/jeo-phi</phiOutputDir>
+            </configuration>
+          </execution>
+          <execution>
+            <id>convert-xmir-to-eo</id>
+            <phase>process-classes</phase>
+            <goals>
+              <goal>print</goal>
+            </goals>
+            <configuration>
+              <printSourcesDir>${project.build.directory}/generated-sources/jeo-xmir</printSourcesDir>
+              <printOutputDir>${project.build.directory}/generated-sources/jeo-eo</printOutputDir>
             </configuration>
           </execution>
         </executions>

diff --git a/src/it/bytecode-to-eo/verify.groovy b/src/it/bytecode-to-eo/verify.groovy
@@ -30,5 +30,6 @@ assert log.contains("WithoutPackage.class' disassembled to ")
 assert log.contains("BUILD SUCCESS")
 //Check that we have generated XMIR object file.
 assert new File(basedir, 'target/generated-sources/jeo-xmir/org/eolang/jeo/Application.xmir').exists()
-//assert new File(basedir, 'target/generated-sources/jeo-eo/org/eolang/jeo/Application.eo').exists()
+assert new File(basedir, 'target/generated-sources/jeo-eo/org/eolang/jeo/Application.eo').exists()
+assert new File(basedir, 'target/generated-sources/jeo-phi/org/eolang/jeo/Application.phi').exists()
 true