-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#540): Compute Max Locals And Stack #744
Merged
rultor
merged 54 commits into
objectionary:master
from
volodya-lombrozo:540_compute_maxs
Oct 10, 2024
Merged
feat(#540): Compute Max Locals And Stack #744
rultor
merged 54 commits into
objectionary:master
from
volodya-lombrozo:540_compute_maxs
Oct 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l calculations. Try-with-resources remains
…blem with variables size
@rultor merge |
@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here. |
@volodya-lombrozo Done! FYI, the full log is here (took me 8min). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying on Java ASM library, we can count
max_locals
andmax_stack
values ourselves.This changes allow to remove the ad-hoc solution related to switching computation modes in Java ASM library.
Closes: #540.
PR-Codex overview
This PR primarily focuses on refactoring the
BytecodeInstructionEntry
toBytecodeInstruction
, adding methods for calculating the impact on stack and local variables, and enhancing theBytecodeMethod
class to manage instructions and compute max stack and locals.Detailed summary
BytecodeInstructionEntry
toBytecodeInstruction
.impact()
method to calculate stack impact.MaxStack
andMaxLocals
classes for computing maximum stack and local variables.BytecodeMethod
for managing instructions and computing maxs.