feat(#757): Exclude roll-data.xsl Transformation From Unrolling
#760
+52
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maxonfjvipon Could you take a look, please? |
maxonfjvipon
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
@volodya-lombrozo Looks good, seems everything works fine without the transformation
|
@rultor merge |
@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here. |
@volodya-lombrozo Done! FYI, the full log is here (took me 11min). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I excluded
roll-data.xslfrom the suggested unrolling train.Related to #757
PR-Codex overview
This PR focuses on enhancing the
CanonicalXmirfunctionality by modifying the transformation process and adding a new test case to ensure correct unrolling of sequences in an XML representation.Detailed summary
TrClasspathinCanonicalXmir.javato include a new file and remove two others.Directives,ImpossibleModificationException, andXemblyinCanonicalXmirTest.java.unrollsSequenceOfValuesCorrectlyto validate the unrolling of values in XML.