Fixes #2409 Stomach neuroendocrine cells now classified under grouping term #2533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JABelfiore
changed the title
|
#gogoeditdiff |
Here's a diff of how these changes impact the classified ontology (on -simple file):Ontology comparisonLeft
Right
Ontology importsOntology annotationsstomach neuroendocrine cell
|
Here's a diff of your edit file (unreasoned)Ontology comparisonLeft
Right
Ontology importsOntology annotationsstomach enteroendocrine cell
|
Some more tweaks to fix hierarchy
|
#gogoeditdiff |
Caroline-99
requested changes
Sep 24, 2024
src/ontology/cl-edit.owl
Outdated
| @@ -7755,6 +7756,7 @@ AnnotationAssertion(oboInOwl:hasDbXref obo:CL_0000508 "FMA:67609") | |||
| AnnotationAssertion(oboInOwl:hasExactSynonym obo:CL_0000508 "G cell") | |||
| AnnotationAssertion(rdfs:label obo:CL_0000508 "type G enteroendocrine cell") | |||
There was a problem hiding this comment.
Type G enteroendocrine cell is not exclusively found in the stomach, it is also found in duodenum and pancreas (https://en.wikipedia.org/wiki/G_cell). It has been inferred that Type G enteroendocrine cell is a subclass of stomach neuroendocrine cell.
To remain consistent with the other patterns, I would suggest keeping Type G enteroendocrine cell as a broad term (e.g. enteroendocrine cell and neuroendocrine cell and gastrin secreting cell and enkephalin secreting cell.
Then create a specific term type G cell of stomach that is type G enteroendocrine cell
and ('part of' some 'epithelium of stomach') or 'part of' some 'mucosa of pyloric antrum'
src/ontology/cl-edit.owl
Outdated
| @@ -27731,7 +27734,7 @@ EquivalentClasses(obo:CL_1001516 ObjectIntersectionOf(obo:CL_0000164 ObjectSomeV | |||
|
|
|||
| AnnotationAssertion(Annotation(oboInOwl:hasDbXref "MP:0010803") obo:IAO_0000115 obo:CL_1001517 "The various hormone- or neurotransmitter-secreting cells present throughout the mucosa of the stomach.") | |||
| AnnotationAssertion(rdfs:label obo:CL_1001517 "stomach enteroendocrine cell") | |||
There was a problem hiding this comment.
Please add more information for this term stomach enteroendocrine cell - (ie. references).
Also, the stomach neuroendocrine cell lacks a textual defs, references, synonyms etc.
This could be done in a separate ticket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stomach neuroendocrine cells now classified under grouping term