Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better unicode.ml generator #141

Merged
merged 4 commits into from
Jun 28, 2023
Merged

Better unicode.ml generator #141

merged 4 commits into from
Jun 28, 2023

Conversation

hhugo
Copy link
Contributor

@hhugo hhugo commented Jun 26, 2023 •
edited
Loading

  • no longer extract information from comments
  • extract missing information from UnicodeData.txt
  • track ignored properties so that one can codereview them
  • make the parsing of Unicode data fail if lines don't have the expected format.

Based on #144

@hhugo hhugo force-pushed the better-gen branch 2 times, most recently from 7b35e66 to 64accc0 Compare June 26, 2023 08:10
@hhugo
Copy link
Contributor Author

hhugo commented Jun 26, 2023

I've extracted some fix in #144

@hhugo hhugo force-pushed the better-gen branch 2 times, most recently from 89cf170 to 5932d30 Compare June 26, 2023 11:41
@hhugo
Copy link
Contributor Author

hhugo commented Jun 26, 2023

This is now based on top of #144.
Only the last commit is part of this PR.
once #144 is merged, this PR will only change how unicode.ml is generated but will no change its content.

toots
toots reviewed Jun 26, 2023
View reviewed changes
Copy link
Member

@toots toots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great too. I'll have another pass once the parent PR is merged.

src/generator/gen_unicode.ml Outdated Show resolved Hide resolved
src/generator/gen_unicode.ml Outdated Show resolved Hide resolved
src/generator/gen_unicode.mli Outdated Show resolved Hide resolved
@hhugo
Copy link
Contributor Author

hhugo commented Jun 27, 2023

I've rebased this PR. ready for another round of review

toots
toots approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@toots toots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks.

@toots toots merged commit fad335a into ocaml-community:master Jun 28, 2023
8 checks passed
@hhugo hhugo deleted the better-gen branch June 28, 2023 06:52
@hhugo hhugo mentioned this pull request Jun 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toots toots toots approved these changes

@alainfrisch alainfrisch Awaiting requested review from alainfrisch alainfrisch is a code owner

@Drup Drup Awaiting requested review from Drup Drup is a code owner

@pmetzger pmetzger Awaiting requested review from pmetzger pmetzger is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hhugo @toots