-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Coq.8.20.0 #26478
Add Coq.8.20.0 #26478
Conversation
@MSoegtropIMC you're certainly our best Windows expert, does the CI error here ring a bell:
|
No, sorry. If the same stuff works elsewhere it is likely an issue with handling absolute paths. Note that in Coq Platform I am using a patched version of ocamlfind which handles paths very differently. The main reason for the patch is to make ocamlfind relocatable, but it is also avoids a lot of issues with paths on Windows. |
Ok, thanks for the answer. |
I proposed the patch in ocaml/ocamlfind#60 but OCaml wants to follow a different approach (which does not work for Coq Platform - at least not without quite a bit of extra work). |
I reviewed the discussion there and I still think we won't converge on this. Making Windows / MacOS installers for OCaml software still seems to be a niche application. |
So, CI seems green except:
|
@proux01 : any idea why it did work for 8.19? Also note that Coq Platform does build Coq via opam on Windows. I think we should at least test if this works with the patched ocamlfind. |
Are you sure it worked for 8.19? My understanding is that OPAM for windows is a recent thing and it just wan't tested then. |
Coq Platform builds Coq using opam on Windows since 8.13, so yes I am sure this works. But we are using cygwin as build host - otherwise many opam packages won't build because they need a Posix shell (e.g. for configure scripts). |
Yes, that's what I meant, Coq CI for windows based on the platform is green but this precise OPAM CI was probably just never tested before. |
Indeed if this is a direct opam on WIndows CI I wouldn't expect that it works. How far does it get? |
As you can see, it doesn't go past |
This is indeed a new test, and not a blocker. The other builds look fine to me to merge. |
Thanks |
Thanks! |
Cc @silene (coRM) and @palmskog (who did many previous Coq packages)