Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Coq.8.20.0 #26478

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Add Coq.8.20.0 #26478

merged 1 commit into from
Sep 6, 2024

Conversation

proux01
Copy link
Contributor

@proux01 proux01 commented Sep 4, 2024

Cc @silene (coRM) and @palmskog (who did many previous Coq packages)

@proux01
Copy link
Contributor Author

proux01 commented Sep 5, 2024

@MSoegtropIMC you're certainly our best Windows expert, does the CI error here ring a bell:

Uncaught exception: Invalid_argument("index out of bounds")
Error while running 'D:\opamroot\default\bin/ocamlfind.exe ocamlc -version' (exit code 3)
Configuration script failed!

@MSoegtropIMC
Copy link
Contributor

No, sorry. If the same stuff works elsewhere it is likely an issue with handling absolute paths. Note that in Coq Platform I am using a patched version of ocamlfind which handles paths very differently. The main reason for the patch is to make ocamlfind relocatable, but it is also avoids a lot of issues with paths on Windows.

@proux01
Copy link
Contributor Author

proux01 commented Sep 5, 2024

Ok, thanks for the answer.
By the way, do you have any plan to sbmit you ocamlfind patch upstream?

@MSoegtropIMC
Copy link
Contributor

I proposed the patch in ocaml/ocamlfind#60 but OCaml wants to follow a different approach (which does not work for Coq Platform - at least not without quite a bit of extra work).

@MSoegtropIMC
Copy link
Contributor

I reviewed the discussion there and I still think we won't converge on this. Making Windows / MacOS installers for OCaml software still seems to be a niche application.

@proux01 proux01 marked this pull request as ready for review September 5, 2024 15:11
@proux01
Copy link
Contributor Author

proux01 commented Sep 5, 2024

So, CI seems green except:

  • the framac reverse dependencies but that looks like some unrelated lablgtk3 issue
  • Windows: according to the above discussion, it seems we have no hope to rapidly solve this, so the current PR should probably be merged so that users not using opam on windows (probably a vast majority of users currently) get the latest Coq release (and we can still try to fix windows later)

@MSoegtropIMC
Copy link
Contributor

@proux01 : any idea why it did work for 8.19? Also note that Coq Platform does build Coq via opam on Windows. I think we should at least test if this works with the patched ocamlfind.

@proux01
Copy link
Contributor Author

proux01 commented Sep 5, 2024

Are you sure it worked for 8.19? My understanding is that OPAM for windows is a recent thing and it just wan't tested then.

@MSoegtropIMC
Copy link
Contributor

Coq Platform builds Coq using opam on Windows since 8.13, so yes I am sure this works. But we are using cygwin as build host - otherwise many opam packages won't build because they need a Posix shell (e.g. for configure scripts).

@MSoegtropIMC
Copy link
Contributor

@proux01
Copy link
Contributor Author

proux01 commented Sep 5, 2024

Yes, that's what I meant, Coq CI for windows based on the platform is green but this precise OPAM CI was probably just never tested before.

@MSoegtropIMC
Copy link
Contributor

Indeed if this is a direct opam on WIndows CI I wouldn't expect that it works. How far does it get?

@proux01
Copy link
Contributor Author

proux01 commented Sep 5, 2024

As you can see, it doesn't go past ocamlc -version in the configure script.

@avsm
Copy link
Member

avsm commented Sep 5, 2024

This is indeed a new test, and not a blocker. The other builds look fine to me to merge.

@mseri mseri merged commit c72b8be into ocaml:master Sep 6, 2024
1 of 3 checks passed
@mseri
Copy link
Member

mseri commented Sep 6, 2024

Thanks

@proux01
Copy link
Contributor Author

proux01 commented Sep 6, 2024

Thanks!

@proux01 proux01 deleted the coq820 branch September 6, 2024 07:29
@proux01 proux01 mentioned this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants