Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.3 compat (ppx_deriving, dream-httpaf) #26654

Merged
merged 2 commits into from
Oct 4, 2024
Merged

5.3 compat (ppx_deriving, dream-httpaf) #26654

merged 2 commits into from
Oct 4, 2024
+2 −2

Commits on Oct 2, 2024

  1. ppx_deriving is not compatible with 5.3: 

    ```
=== ERROR while compiling ppx_deriving.6.0.2 =================================#
 context     2.2.1 | linux/x86_64 | ocaml-base-compiler.5.3.0~alpha1 | file:///home/opam/opam-repository
 path        ~/.opam/5.3~alpha1/.opam-switch/build/ppx_deriving.6.0.2
 command     ~/.opam/5.3~alpha1/bin/dune build -p ppx_deriving -j 255
 exit-code   1
 env-file    ~/.opam/log/ppx_deriving-1-37872c.env
 output-file ~/.opam/log/ppx_deriving-1-37872c.out
 ## output ###
 (cd _build/default && /home/opam/.opam/5.3~alpha1/bin/ocamlopt.opt -I src/.ppx_deriving_main.eobjs/byte -I src/.ppx_deriving_main.eobjs/native -I /home/opam/.opam/5.3~alpha1/lib/findlib -I /home/opam/.opam/5.3~alpha1/lib/ocaml/dynlink -intf-suffix .ml-gen -no-alias-deps -opaque -o src/.ppx_deriving_main.eobjs/native/findlib_initl.cmx -c -impl src/.ppx_deriving_main.eobjs/findlib_initl.ml-gen)
 File "_none_", line 1:
 Warning 58 [no-cmx-file]: no cmx file was found in path for module Findlib, and its interface was not compiled with -opaque
 (cd _build/default && /home/opam/.opam/5.3~alpha1/bin/ocamlopt.opt -w -40 -w -27-9 -g -I src/api/.ppx_deriving_api.objs/byte -I src/api/.ppx_deriving_api.objs/native -I /home/opam/.opam/5.3~alpha1/lib/ocaml-compiler-libs/common -I /home/opam/.opam/5.3~alpha1/lib/ocaml-compiler-libs/shadow -I /home/opam/.opam/5.3~alpha1/lib/ocaml/compiler-libs -I /home/opam/.opam/5.3~alpha1/lib/ppx_derivers -I /home/opam/.opam/5.3~alpha1/lib/ppxlib -I /home/opam/.opam/5.3~alpha1/lib/ppxlib/ast -I /home/opam/.opam/5.3~alpha1/lib/ppxlib/astlib -I /home/opam/.opam/5.3~alpha1/lib/ppxlib/print_diff -I /home/opam/.opam/5.3~alpha1/lib/ppxlib/stdppx -I /home/opam/.opam/5.3~alpha1/lib/ppxlib/traverse_builtins -I /home/opam/.opam/5.3~alpha1/lib/sexplib0 -I /home/opam/.opam/5.3~alpha1/lib/stdlib-shims -intf-suffix .ml -no-alias-deps -o src/api/.ppx_deriving_api.objs/native/ppx_deriving.cmx -c -impl src/api/ppx_deriving.pp.ml)
 File "ppx_deriving.cppo.ml", line 181, characters 30-33:
 Error: The value sub has type
          (Format.formatter -> unit) Ppxlib.Asttypes.loc list option
        but an expression was expected of type Location.msg list option
        Type
          (Format.formatter -> unit) Ppxlib.Asttypes.loc =
            (Format.formatter -> unit) Location.loc
        is not compatible with type Location.msg = Format_doc.t Location.loc
        Type Format.formatter -> unit is not compatible with type
          Format_doc.t = Format_doc.Doc.t
 (cd _build/default && /home/opam/.opam/5.3~alpha1/bin/ocamlc.opt -w -40 -w -27-9 -g -bin-annot -bin-annot-occurrences -I src/api/.ppx_deriving_api.objs/byte -I /home/opam/.opam/5.3~alpha1/lib/ocaml-compiler-libs/common -I /home/opam/.opam/5.3~alpha1/lib/ocaml-compiler-libs/shadow -I /home/opam/.opam/5.3~alpha1/lib/ocaml/compiler-libs -I /home/opam/.opam/5.3~alpha1/lib/ppx_derivers -I /home/opam/.opam/5.3~alpha1/lib/ppxlib -I /home/opam/.opam/5.3~alpha1/lib/ppxlib/ast -I /home/opam/.opam/5.3~alpha1/lib/ppxlib/astlib -I /home/opam/.opam/5.3~alpha1/lib/ppxlib/print_diff -I /home/opam/.opam/5.3~alpha1/lib/ppxlib/stdppx -I /home/opam/.opam/5.3~alpha1/lib/ppxlib/traverse_builtins -I /home/opam/.opam/5.3~alpha1/lib/sexplib0 -I /home/opam/.opam/5.3~alpha1/lib/stdlib-shims -intf-suffix .ml -no-alias-deps -o src/api/.ppx_deriving_api.objs/byte/ppx_deriving.cmo -c -impl src/api/ppx_deriving.pp.ml)
 File "ppx_deriving.cppo.ml", line 181, characters 30-33:
 Error: The value sub has type
          (Format.formatter -> unit) Ppxlib.Asttypes.loc list option
        but an expression was expected of type Location.msg list option
        Type
          (Format.formatter -> unit) Ppxlib.Asttypes.loc =
            (Format.formatter -> unit) Location.loc
        is not compatible with type Location.msg = Format_doc.t Location.loc
        Type Format.formatter -> unit is not compatible with type
          Format_doc.t = Format_doc.Doc.t
```
    @hannesm
    hannesm committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    e4a3929 View commit details
    Browse the repository at this point in the history

  2. dream-httpaf is not compatible with ocaml 5.3: 

    ```
=== ERROR while compiling dream-httpaf.1.0.0~alpha3 ==========================#
 context     2.2.1 | linux/x86_64 | ocaml-base-compiler.5.3.0~alpha1 | file:///home/opam/opam-repository
 path        ~/.opam/5.3~alpha1/.opam-switch/build/dream-httpaf.1.0.0~alpha3
 command     ~/.opam/5.3~alpha1/bin/dune build -p dream-httpaf -j 255
 exit-code   1
 env-file    ~/.opam/log/dream-httpaf-1-ea8029.env
 output-file ~/.opam/log/dream-httpaf-1-ea8029.out
 ## output ###
 (cd _build/default && /home/opam/.opam/5.3~alpha1/bin/ocamlc.opt -w -40 -g -bin-annot -bin-annot-occurrences -I src/vendor/h2/hpack/util/.gen_huffman.eobjs/byte -I /home/opam/.opam/5.3~alpha1/lib/ocaml/compiler-libs -no-alias-deps -open Dune__exe -o src/vendor/h2/hpack/util/.gen_huffman.eobjs/byte/dune__exe__Gen_huffman.cmo -c -impl src/vendor/h2/hpack/util/gen_huffman.ml)
 File "src/vendor/h2/hpack/util/gen_huffman.ml", line 113, characters 28-71:
 113 |              [ Exp.constant (Pconst_integer (string_of_int code, None))
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 Error: This expression should not be a constructor, the expected type is
        Parsetree.constant
```
    @hannesm
    hannesm committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    985a9db View commit details
    Browse the repository at this point in the history