-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable and disable automated security features #1705
Conversation
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
@@ -609,4 +609,38 @@ | |||
expect(result).to be true | |||
end | |||
end # .disable_vulnerability_alerts | |||
|
|||
describe '.automated_security_fixes_enabled?', :vcr do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this come with VCR updates?
I'm not sure why I'm not seeing the prompt to approve the Actions test run; perhaps it has something to do with the new merge box UI. Either way, I'd expect these tests to need VCR updates to pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should, i misunderstood the process. Now attached.
75fc060
to
843ea20
Compare
# @example | ||
# @client.automated_security_fixes_enabled?("octokit/octokit.rb") | ||
def automated_security_fixes_enabled?(repo, options = {}) | ||
response = get "#{Repository.path repo}/automated-security-fixes", options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a boolean_from_response capable endpoint; it always returns 200 with an object:
Note that unlike the docs, it does not return 404 if not enabled, it always returns the object (with enabled: false).
Resolves #1704
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?