[REF] runbot: Get repo data from json request of github webhook #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moylop260
force-pushed
the
master-hook-org-moy
branch
from
8c69fa5
to
99ba9e2
Compare
|
ping @odony |
| event = request.httprequest.headers.get("X-Github-Event") | ||
| if repo_data and event in ['push', 'pull_request']: | ||
| repo_owner = repo_data['owner'].get('name') or repo_data['owner'].get('login') | ||
| repo_name = repo_data['name'] |
There was a problem hiding this comment.
Instead of parsing repo.owner.name/login and repo.name, why don't you use repo.full_name directly?
|
Thanks! |
|
@odony |
moylop260
force-pushed
the
master-hook-org-moy
branch
from
68f8bb4
to
a0e3af1
Compare
odony
force-pushed
the
master
branch
5 times, most recently
from
a526286
to
d7ce0df
Compare
moylop260
force-pushed
the
master-hook-org-moy
branch
from
a0e3af1
to
dde8c39
Compare
odony
force-pushed
the
master
branch
2 times, most recently
from
ab648fe
to
9bd4838
Compare
moylop260
force-pushed
the
master-hook-org-moy
branch
2 times, most recently
from
321b79d
to
3214887
Compare
moylop260
force-pushed
the
master-hook-org-moy
branch
from
3214887
to
ca81015
Compare
|
@odony |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse the json request to find the right repo.