Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sagemaker quality of life improvements #245

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

oegedijk
Copy link
Owner

@oegedijk oegedijk commented Jan 1, 2023

No description provided.

@oegedijk
Copy link
Owner Author

oegedijk commented Jan 1, 2023

@absynthe started a new PR with the quality of life improvements. BTW, do you maybe know how to detect whether we're in a sagemaker environment?

@oegedijk
Copy link
Owner Author

oegedijk commented Jan 1, 2023

so something similar to

ipython_kernel = str(get_ipython())
self.is_notebook = True
self.is_colab = True if 'google.colab' in ipython_kernel else False

@oegedijk
Copy link
Owner Author

oegedijk commented Jan 2, 2023

@absynthe I've been toying around with sagemaker studio today, but so far haven't been able to get the dash to run, do you have a guide or HOWTO?

@absynthe
Copy link
Contributor

Hey @oegedijk, I created this working example for you: https://github.com/absynthe/explainer-dashboard-studio-working-example/blob/main/workingExplainerDashboardStudioExample.ipynb . Try to walk through it and let me know if you have any questions.

@absynthe
Copy link
Contributor

so something similar to

ipython_kernel = str(get_ipython())
self.is_notebook = True
self.is_colab = True if 'google.colab' in ipython_kernel else False

There is nothing in the kernel giving SageMaker studio away. However, you can look for the /opt/ml/metadata/resource-metadata.json file in the file system.

@absynthe
Copy link
Contributor

Hi again @oegedijk , I added a test for kwargs: absynthe/explainer-dashboard-studio-working-example@7066886 . This does not seem to work, I assume something is missing for the cli glue to work?

We cannot run the dashboard directly in the notebookn using the run command. This is due to the separation between compute and storage of SageMaker Studio as mentioned here: https://aws.amazon.com/blogs/machine-learning/dive-deep-into-amazon-sagemaker-studio-notebook-architecture/ .

This is why there is the workaround of exporting the dashboard config to disk and loading again in the terminal window of the JupyterServer App.

@DannyDannyDanny
Copy link

We'd very much like to start using explainer dashboard on SageMaker. Is there anything I can do to help push this forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants