-
Notifications
You must be signed in to change notification settings - Fork 173
add cacheSearchTerm option #251
base: dev
Are you sure you want to change the base?
Conversation
thanks for the PR. there is already an |
Top-level index.ts is a copy of src one, with "src/" added to all import paths |
can you split it to 2 PR's? |
Ok, removed index.ts for now (but left that commit unchanged because I already depend on it in my project), will do something about index.ts or typings in the next PR |
can you change it so that |
bug: unnecessary search reload when cacheSearchTerm is false when KEY_DOWN event occurs leads to incorrect behavior
@@ -83,7 +83,7 @@ export class CtrInput { | |||
else if (event.keyCode === KEY_DW) { | |||
event.preventDefault(); | |||
|
|||
this.completer.search(this.searchStr); | |||
if (!this.completer.opened) { this.completer.search(this.searchStr) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what was the issue here?
version 1.5.4 now includes |
@oferh do you know when this PR will be merged? I am using |
Add cacheSearchTerm option (defaults to true, the same behavior as before) to mitigate #168
To fix the issue set cacheSearchTerm attribute of the ng2-completer to true.
Also add index.ts file, so ng2-completer could be installed from github like this: "yarn add yarn add https://github.com/oferh/ng2-completer