Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Change type of search_total_cycles/search_total_ms_run metrics #962

Conversation

nantiferov
Copy link
Contributor

Initially added in #953 as gauges, but usage shows that they're counters.
I'm not sure if there are many users of this feature, but technically metrics rename might break some dashboards/alerts.

Related: #942

Initially added in oliver006#953 as gauges, but usage shows that they're counters.

Related: oliver006#942
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.05%. Comparing base (8efb8fa) to head (c9ea61f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #962   +/-   ##
=======================================
  Coverage   82.05%   82.05%           
=======================================
  Files          18       18           
  Lines        2636     2636           
=======================================
  Hits         2163     2163           
  Misses        386      386           
  Partials       87       87           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11575892083

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.406%

Totals Coverage Status
Change from base Build 11529082829: 0.0%
Covered Lines: 2259
Relevant Lines: 2645

💛 - Coveralls

@nantiferov
Copy link
Contributor Author

Dashboard with rate:
image

And without:
image

Current state doesn't block anything, but I think it would be correct to define these metrics as counters and fix naming:
image

@nantiferov nantiferov marked this pull request as ready for review October 29, 2024 14:28
@oliver006
Copy link
Owner

I'm not sure if there are many users of this feature, but technically metrics rename might break some dashboards/alerts.

Yeah, I think this is still early so we can just change it without too much ado. Appreciate the concern though.

@oliver006 oliver006 merged commit d9ccc72 into oliver006:master Oct 31, 2024
9 checks passed
@oliver006
Copy link
Owner

@nantiferov
Copy link
Contributor Author

Thank you for review and release 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants