Prevent timing attack on CSRF #123
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eutopian
force-pushed
the
master
branch
5 times, most recently
from
b547a44
to
1517196
Compare
|
Hey! Would you mind rebasing on master and removing all |
|
@tmilewski Hi! Just did that, thanks! |
|
Prefect, thank you! I’ll try and get this pushed up later today.
Thanks again!
…On Dec 19, 2018, 2:35 PM -0800, Margaret Ma ***@***.***>, wrote:
@tmilewski Hi! Just did that, thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Closing and reopening to trigger CI |
| @@ -87,6 +87,16 @@ def app | |||
| instance.callback_phase | |||
| end | |||
| end | |||
|
|
|||
| describe "#secure_params" do | |||
There was a problem hiding this comment.
Suggested change
| describe "#secure_params" do | |
| describe "#secure_compare" do |
|
I don't have permission to write to this fork but was wondering if it's possible to get this PR over the line (or the new PR I just opened which resolves the merge conflicts and spec rename) to fix an outstanding security vuln that's also affecting omniauth-auth0 downstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use secure_compare instead of plain equality comparison on request and callback state to prevent timing attacks.