Fix pytest error due to deprecation warning #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5b6257b.
|
/poke @omry not sure if you've seen this |
Jasha10
reviewed
Jul 20, 2023
Jasha10
approved these changes
Jul 20, 2023
|
lgtm |
omry
approved these changes
Jul 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1100
The fix is similar to what was done in facebookresearch/hydra#2696, instead of pinning a specific version of setuptools as in #1068
I'll mark this PR as draft since I still need to check if #1069 can be reverted now.
[Update: I double checked and we can indeed revert #1069 now, so adding it to this PR]