-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/testing #81
Open
sofisdev
wants to merge
20
commits into
main
Choose a base branch
from
feat/testing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/testing #81
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
d13e985
update builder tests
sofisdev ed977c6
testing builder
sofisdev 2aed13f
integration testing builder
sofisdev 6365bee
json validation util
sofisdev 6bb71aa
Merge branch 'main' of https://github.com/guidesmiths/react-form-buil…
sofisdev 68762a0
Merge branch 'main' of https://github.com/guidesmiths/react-form-buil…
sofisdev f2641f8
update validation json
sofisdev 37129f8
update json validation
sofisdev 2deef96
update json validation dependant questions
sofisdev 4a8affa
refactor json validation
sofisdev 42a0a85
refactor and delete unused package
sofisdev 5593741
added id to question validation and dependentQuestion example to form…
sofisdev 963c705
testing dependentQuestions Schema
sofisdev 72f4d3a
merge conflicts fix
sofisdev dba9fcf
update log json validator
sofisdev 3952148
checking tests
sofisdev a4703aa
Merge branch 'main' of https://github.com/guidesmiths/react-form-buil…
sofisdev 2cda3e2
Merge branch 'main' of https://github.com/guidesmiths/react-form-buil…
sofisdev c32e468
fix: merge changes
sofisdev 0f5ecb4
feat: add console.log test for json verification
sofisdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should avoid truly expressions. The reason behind this is if I'm passing to boolean expressions let say
validateJSON
andnotValidateJSON
I would not know the behavior without going to the implementation details. Think components as functions, passing booleans as arguments makes the function really hard to maintain. I'd use some sort of state handling @sofisdev