Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model zoo revamp #636

Merged
merged 17 commits into from
Dec 8, 2023
Merged

Model zoo revamp #636

merged 17 commits into from
Dec 8, 2023

Conversation

ramkrishna2910
Copy link
Contributor

This PR revamps the onnx model zoo by adding ~2000 new onnx files across computer vision, natural language processing, generative ai and graph machine learning.

@ramkrishna2910 ramkrishna2910 self-assigned this Dec 1, 2023
Copy link
Member

@jcwchen jcwchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for bringing ~2000 models into the zoo! It's existing to see there are more state-of the-art models in the Zoo.

Two concerns:
(1) About moving deprecated models into another directory "archive": please update https://github.com/onnx/models/blob/main/ONNX_HUB_MANIFEST.json accordingly with the new paths for those old models. ONNX_HUB_MANIFEST.json is used by onnx package's onnx.hub. onnx.hub always downloads the models from the latest main branch of ONNX model zoo repo. That is to say, if we simply change the directory path without updating ONNX_HUB_MANIFEST.json, onnx.hub will be broken. The update for that .json file should be trivial and you can simply run python workflow_scripts/generate_onnx_hub_manifest.py under the root directory of model zoo repo with the new model paths.
(2) For now the tests for running onnx.checker and onnxruntime CPU EP were removed in this PR. Please add new corresponding tests powered by TurnkeyML ASAP to ensure these new models are all well tested. Also, we should still cover producing ONNX_HUB_MANIFEST.json in the CI to ensure ONNX_HUB_MANIFEST.json is always updated. For instance,

- name: Test updated ONNX_HUB_MANIFEST.json
run: |
python -m pip install typepy BeautifulSoup4 markdown pandas
python workflow_scripts/generate_onnx_hub_manifest.py --target diff --drop
git diff --exit-code -- ONNX_HUB_MANIFEST.json || { echo 'Please use "python workflow_scripts/generate_onnx_hub_manifest.py --target diff" to update ONNX_HUB_MANIFEST.json.' ; exit 1; }

(1) is prioritized. Please let me know if you have any issue with it. Thank you for your huge effort!

@ramkrishna2910
Copy link
Contributor Author

The ONNX HUB manifest has been fixed to work with the new folder structure. And I have opened a separate issue #637 for adding TKML based tests for model acceptance.

Copy link
Member

@jcwchen jcwchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I tried to run an experiment as:

from onnx import hub
# 5ef7a840a378cdbe9014ae678e82666a35c09480 is the commit of current development branch
model = hub.load("resnet50", repo="onnx/models:5ef7a840a378cdbe9014ae678e82666a35c09480")

And the new path seems to work perfectly. Thank you for upadting.

@ramkrishna2910 ramkrishna2910 merged commit 69d6901 into main Dec 8, 2023
3 checks passed
@ramkrishna2910 ramkrishna2910 deleted the development branch December 8, 2023 20:22
cjvolzka added a commit to IBM/zDLC that referenced this pull request Dec 12, 2023
Update to match onnx model zoo changes onnx/models#636
Signed-off-by: Charles Volzka <[email protected]>
cjvolzka added a commit to cjvolzka/zDLC that referenced this pull request Dec 12, 2023
Update to match onnx model zoo changes onnx/models#636

Signed-off-by: Charles Volzka <[email protected]>
cjvolzka added a commit to IBM/zDLC that referenced this pull request Dec 12, 2023
Update to match onnx model zoo changes onnx/models#636

Signed-off-by: Charles Volzka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants