Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add read_mbytes and write_mbytes from statistics #124

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

paultag
Copy link

@paultag paultag commented Mar 2, 2018

This is a bit awkward at the moment, and should perhaps be refactored
into more statistical helpers, but for now, being able to grab the
read/write count to the device is fairly handy.

This is a bit awkward at the moment, and should perhaps be refactored
into more statistical helpers, but for now, being able to grab the
read/write count to the device is fairly handy.
@paultag
Copy link
Author

paultag commented Mar 2, 2018

I put this into StorageObject - I'm not sure if this depends on a particular backstore. If so, I'll pull this into either a function or a mixin that we can throw into the supported backstores.

Just a flag if anyone knows

@mikechristie
Copy link

Would it be possible to make it more generic similar to how we get attributes/params?

For example, check out node.py:list_attributes() for how to loop over the statistics dir and put all of them in an array. We could then also do something like node.py:get_attribute() to get individual stats if needed.

I think we could get this to work at the storage object and target levels similar to how the attribute code works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants