Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set T10 Vendor ID for backstore #136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

os-d
Copy link

@os-d os-d commented May 22, 2019

Signed-off-by: Oliver Smith-Denny [email protected]

David Disseldorp's kernel patch (https://patchwork.kernel.org/patch/10707421/) added the ability to set the T10 vendor ID for a backstore in ConfigFS. This patch give targetcli-fb the functionality to set that vendor ID at backstore creation time. There is also a pending PR in rtslib-fb to match this functionality on the backend side.

Please give me your comments, I am happy to make any changes. I set this ability for ramdisks and block storage as those are my two use cases. PSCSI already has the ability to get the vendor and a vendor ID seemed to make less sense for FileIO, although that easily could be added. I only let the vendor ID be set at backstore creation time, as it is unlikely the vendor would change throughout the lifetime of the backstore (this could also be changed).

I tested with a new kernel that include's the above patch and I tested on a kernel without the patch. I also tested that saveconfig and restoreconfig work as expected on both kernels, when the vendor ID is present in the json file and when it is not. My test results showed no crashes and the vendor ID being properly displayed on the newer kernel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant