Skip to content

Commit

Permalink
Change S0 calculation to enforce Again < Hard < Good < Easy.py
Browse files Browse the repository at this point in the history
  • Loading branch information
Expertium authored Aug 24, 2024
1 parent ef723f8 commit 7c06b41
Showing 1 changed file with 12 additions and 11 deletions.
23 changes: 12 additions & 11 deletions src/fsrs_optimizer/fsrs_optimizer.py
Original file line number Diff line number Diff line change
Expand Up @@ -166,9 +166,9 @@ def __call__(self, module):
if hasattr(module, "w"):
w = module.w.data
w[0] = w[0].clamp(S_MIN, 100)
w[1] = w[1].clamp(S_MIN, 100)
w[2] = w[2].clamp(S_MIN, 100)
w[3] = w[3].clamp(S_MIN, 100)
w[1] = w[1].clamp(w[0] * 1.05, 100)
w[2] = w[2].clamp(w[1] * 1.05, 100)
w[3] = w[3].clamp(w[2] * 1.05, 100)
w[4] = w[4].clamp(1, 10)
w[5] = w[5].clamp(0.01, 4)
w[6] = w[6].clamp(0.01, 4)
Expand Down Expand Up @@ -1024,14 +1024,15 @@ def loss(stability):
(2, 4),
(1, 4),
):
if small_rating in rating_stability and big_rating in rating_stability:
# if rating_count[small_rating] > 300 and rating_count[big_rating] > 300:
# continue
if rating_stability[small_rating] > rating_stability[big_rating]:
if rating_count[small_rating] > rating_count[big_rating]:
rating_stability[big_rating] = rating_stability[small_rating]
else:
rating_stability[small_rating] = rating_stability[big_rating]
# if small_rating in rating_stability and big_rating in rating_stability:
# # if rating_count[small_rating] > 300 and rating_count[big_rating] > 300:
# # continue
# if rating_stability[small_rating] > rating_stability[big_rating]:
# if rating_count[small_rating] > rating_count[big_rating]:
# rating_stability[big_rating] = rating_stability[small_rating]
# else:
# rating_stability[small_rating] = rating_stability[big_rating]
rating_stability.sort()

w1 = 3 / 5
w2 = 3 / 5
Expand Down

0 comments on commit 7c06b41

Please sign in to comment.