Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize module consumer #9046

Open
8 tasks done
Tracked by #9375
codeboten opened this issue Dec 5, 2023 · 7 comments · May be fixed by #11492
Open
8 tasks done
Tracked by #9375

Stabilize module consumer #9046

codeboten opened this issue Dec 5, 2023 · 7 comments · May be fixed by #11492

Comments

@codeboten
Copy link
Contributor

codeboten commented Dec 5, 2023

Before stabilizing a module, an approver or maintainer must make sure that the following criteria have been met for at least two successive minor version releases:

  • No open issues or PRs in the module that would require breaking changes
  • No TODOs in the module code that would require breaking changes
  • No deprecated symbols in the module
  • No symbols marked as experimental in the module
  • The module follows the Coding guidelines

Please also make sure to publicly announce our intent to stabilize the module on:

  • The #otel-collector CNCF Slack Channel
  • The #opentelemetry CNCF Slack channel
  • A Collector SIG meeting (if unable to attend, just add to the agenda)

To help other people verify the above criteria, please link to the announcement and other links used to complete the above in a comment on this issue.

Once all criteria are met, close this issue by moving this module to the stable module set.

@atoulme
Copy link
Contributor

atoulme commented Dec 19, 2023

git grep TODO gives no results
git grep Deprecated gives no results

@atoulme
Copy link
Contributor

atoulme commented Dec 19, 2023

Published intent on #otel-collector CNCF Slack Channel:
https://cloud-native.slack.com/archives/C01N6P7KR6W/p1703026224363709
Published intent on #opentelemetry CNCF Slack channel:
https://cloud-native.slack.com/archives/CJFCJHG4Q/p1703026318636549

@atoulme
Copy link
Contributor

atoulme commented Dec 19, 2023

Scheduled for SIG meeting 9am 12/19. Please feel free to attend and bring up any items for discussion, your feedback is helpful.

@TylerHelmuth
Copy link
Member

I believe issues are being tracked in https://github.com/open-telemetry/opentelemetry-collector/milestone/31

@atoulme
Copy link
Contributor

atoulme commented Jan 24, 2024

Looks like the milestone doesn't track PRs, just issues. Do we need to reopen #8833?

@atoulme
Copy link
Contributor

atoulme commented Feb 7, 2024

Discussed with maintainers, we can for now not reopen #8833 and keep it out of scope of the consumer 1.0 package.

@mx-psi mx-psi linked a pull request Oct 21, 2024 that will close this issue
@mx-psi mx-psi assigned mx-psi and unassigned TylerHelmuth Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting for reviews
Development

Successfully merging a pull request may close this issue.

4 participants