Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[consumer] Mark module as stable #11492

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Oct 21, 2024

Description

Mark consumer module as stable. This is now possible after #11491, since consumererror is a separate module now.

Link to tracking issue

Fixes #9046

@mx-psi mx-psi marked this pull request as ready for review October 21, 2024 11:29
@mx-psi mx-psi requested a review from a team as a code owner October 21, 2024 11:29
@mx-psi
Copy link
Member Author

mx-psi commented Oct 21, 2024

cc @open-telemetry/collector-approvers

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.63%. Comparing base (f2e05b5) to head (f3d3d8d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11492   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files         442      442           
  Lines       23776    23776           
=======================================
  Hits        21787    21787           
  Misses       1618     1618           
  Partials      371      371           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mx-psi mx-psi requested a review from dmitryax October 21, 2024 11:30
@bogdandrutu
Copy link
Member

I would merge this after the release to not rush it. Are we ok with that?

@mx-psi
Copy link
Member Author

mx-psi commented Oct 21, 2024

I would merge this after the release to not rush it. Are we ok with that?

Definitely, and regardless of the release let's at least wait for a few days at least in case somebody has an objection

@jade-guiton-dd
Copy link
Contributor

It seems that the current API only permits passing signal-agnostic Options to NewLogs/NewMetrics/NewTraces. How sure are we that we will never need or want to implement consumer options that are specific to one particular signal? (As a hypothetical and possibly impractical example, what if once tracing is integrated to the consumer module (#8804), we want to specify attributes from consumed metrics to be included as part of the trace?)

@mx-psi
Copy link
Member Author

mx-psi commented Oct 28, 2024

Fromt he 2024-10-28 Collector stability meeting, @bogdandrutu will take a look and see if we should do #11492 (comment)

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge after today's release if no one has objections

@mx-psi
Copy link
Member Author

mx-psi commented Nov 18, 2024

About #11492 (comment) publicly: we discussed @jade-guiton-dd's comment offline.

The summary is: we can still do this by detecting whether an option is signal specific at construction time and returning an error. Jade's suggestion would still improve the API in that it would move a construction time error into a compile time error, but after trying this out it would be quite complex to implement, so we think we can leave the API as is.

TL;DR: we are good to go :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stabilize module consumer
10 participants