Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver] Move scraper packages into scraper module #11003

Open
mx-psi opened this issue Aug 29, 2024 · 3 comments · May be fixed by #11166 or #11595
Open

[receiver] Move scraper packages into scraper module #11003

mx-psi opened this issue Aug 29, 2024 · 3 comments · May be fixed by #11166 or #11595
Assignees
@jackgopack4
Labels
good first issue Good for newcomers
Milestone
go.opentelemetry....

Comments

@mx-psi
Copy link
Member

mx-psi commented Aug 29, 2024

We have two packages, scrapererror and scraperhelper that are part of the receiver module, but are not necessary for Collector v1 (we only intend to stabilize the OTLP receiver at first).

We can make a new receiver/scraper module that has these two as packages. This would reduce the API surface that we have to stabilize.
@mx-psi mx-psi added the good first issue Good for newcomers label Aug 29, 2024
@mx-psi
Copy link
Member Author

mx-psi commented Aug 29, 2024

As an example of a PR adding a new module, see #11000.

@zzzk1
Copy link
Contributor

zzzk1 commented Sep 7, 2024

Hi @mx-psi , i would like to try.

@mx-psi
Copy link
Member Author

mx-psi commented Sep 9, 2024

@zzzk1 Please give it a try! :)

@zzzk1 zzzk1 linked a pull request Sep 13, 2024 that will close this issue
Open
@jackgopack4 jackgopack4 linked a pull request Nov 4, 2024 that will close this issue
Open
@mx-psi mx-psi unassigned zzzk1 Nov 5, 2024
@jackgopack4 jackgopack4 moved this from Todo to Waiting for reviews in Collector: v1 Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackgopack4 jackgopack4

Labels
good first issue Good for newcomers
Projects
Collector: v1
Status: Waiting for reviews
Milestone
go.opentelemetry.io/receiver 1.0
3 participants
@mx-psi @jackgopack4 @zzzk1