-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create receiver/scraper module and migrate helper/error modules #11595
base: main
Are you sure you want to change the base?
Create receiver/scraper module and migrate helper/error modules #11595
Conversation
a08ec89
to
bdff184
Compare
only failing test is a metrics test that is passing on local VMs, not sure what the issue is there. edit: I had some typos in the go.mod replace statements; once I fixed that it looks like the test passed consistently |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11595 +/- ##
=======================================
Coverage 91.53% 91.53%
=======================================
Files 441 441
Lines 23848 23848
=======================================
Hits 21830 21830
Misses 1645 1645
Partials 373 373 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
I added aliases like @bogdandrutu asked for in #11166 (review) but I am wondering how long these aliases will need to stay? If they are offered in the stable version of receiver, but point to a beta component, does that meet collector 1.0 requirements? |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Description
moves scrapererror and scraperhelper functions to new
receiver/scraper
module in order to assist stabilizing receiver for collector 1.0Link to tracking issue
Fixes #11003
Testing
existing tests are migrated; no new code added and therefore no new tests needed
Documentation
.chloggen files