Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create receiver/scraper module and migrate helper/error modules #11595

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jackgopack4
Copy link
Contributor

Description

moves scrapererror and scraperhelper functions to new receiver/scraper module in order to assist stabilizing receiver for collector 1.0

Link to tracking issue

Fixes #11003

Testing

existing tests are migrated; no new code added and therefore no new tests needed

Documentation

.chloggen files

@jackgopack4 jackgopack4 force-pushed the migrate-scraper-packages-to-module branch from a08ec89 to bdff184 Compare November 4, 2024 20:51
@jackgopack4
Copy link
Contributor Author

jackgopack4 commented Nov 4, 2024

only failing test is a metrics test that is passing on local VMs, not sure what the issue is there.

edit: I had some typos in the go.mod replace statements; once I fixed that it looks like the test passed consistently

@jackgopack4 jackgopack4 marked this pull request as ready for review November 4, 2024 21:15
@jackgopack4 jackgopack4 requested a review from a team as a code owner November 4, 2024 21:15
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.53%. Comparing base (3da496b) to head (6643e39).
Report is 57 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11595   +/-   ##
=======================================
  Coverage   91.53%   91.53%           
=======================================
  Files         441      441           
  Lines       23848    23848           
=======================================
  Hits        21830    21830           
  Misses       1645     1645           
  Partials      373      373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@jackgopack4
Copy link
Contributor Author

I added aliases like @bogdandrutu asked for in #11166 (review) but I am wondering how long these aliases will need to stay? If they are offered in the stable version of receiver, but point to a beta component, does that meet collector 1.0 requirements?

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 20, 2024
@songy23 songy23 removed the Stale label Nov 20, 2024
@mx-psi mx-psi self-requested a review November 21, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[receiver] Move scraper packages into scraper module
2 participants