Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[configtls] Use configtls.NewDefaultClientConfig instead of manually creating struct #11383

Open
5 tasks
mackjmr opened this issue Oct 7, 2024 · 2 comments · May be fixed by #11638 or #11689
Open
5 tasks

[configtls] Use configtls.NewDefaultClientConfig instead of manually creating struct #11383

mackjmr opened this issue Oct 7, 2024 · 2 comments · May be fixed by #11638 or #11689
Labels
area:config priority:p2 Medium

Comments

@mackjmr
Copy link
Member

mackjmr commented Oct 7, 2024 •
edited
Loading

Describe the issue you're reporting

Move away from manually creating configtls.ClientConfig in favor of using configtls.NewDefaultClientConfig.

This is necessary for the following components:

  • config/configgrpc
  • config/confighttp
  • exporter/otlpexporter
  • exporter/otlphttpexporter
  • internal/e2e
@mackjmr mackjmr changed the title [configtls] Use confighttp.NewDefaultClientConfig instead of manually creating struct [configtls] Use configtls.NewDefaultClientConfig instead of manually creating struct Oct 7, 2024
@mx-psi mx-psi transferred this issue from open-telemetry/opentelemetry-collector-contrib Oct 7, 2024
@mackjmr mackjmr mentioned this issue Oct 7, 2024
Merged
@wasim-nihal
Copy link

Hello @mackjmr ! Is this open for contribution?

@mackjmr
Copy link
Member Author

mackjmr commented Oct 29, 2024

Hi @wasim-nihal, yes this is open for contributions! I've listed in the issue descriptions the components in which this needs to be changed, please link the PRs when you open them similarely to what is done in open-telemetry/opentelemetry-collector-contrib#35457 🙂

@mackjmr mackjmr mentioned this issue Oct 29, 2024
Open
51 tasks
wasim-nihal added a commit to nokia/open-telemetry-opentelemetry-collector that referenced this issue Nov 11, 2024
@wasim-nihal
[configtls] [config/configgrpc] Use configtls.NewDefaultClientConfig …
9c69a8a 
…instead of manually creating struct. See: open-telemetry#11383

Signed-off-by: wasim-nihal <[email protected]>
@wasim-nihal wasim-nihal linked a pull request Nov 11, 2024 that will close this issue
Open
wasim-nihal added a commit to nokia/open-telemetry-opentelemetry-collector that referenced this issue Nov 18, 2024
@wasim-nihal
[configtls] [config/confighttp] Use configtls.NewDefaultClientConfig,…
1c25d03 
… NewDefaultConfig() and NewDefaultServerConfig() instead of manually creating struct. See: open-telemetry#11383

Signed-off-by: wasim-nihal <[email protected]>
@wasim-nihal wasim-nihal linked a pull request Nov 18, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:config priority:p2 Medium
Projects
None yet
Milestone
No milestone
3 participants
@mx-psi @wasim-nihal @mackjmr