Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Renovate for markdown-link-check updates #11606

Open
andrzej-stencel opened this issue Nov 5, 2024 · 2 comments · May be fixed by #11725
Open

Use Renovate for markdown-link-check updates #11606

andrzej-stencel opened this issue Nov 5, 2024 · 2 comments · May be fixed by #11725
Labels
ci-cd CI, CD, testing, build issues enhancement New feature or request release-retro Issues discussed in a release retrospective

Comments

@andrzej-stencel
Copy link
Member

The version of markdown-link-check took has been pinned to a specific version in #11605 due to a bug in the most recent release tcort/markdown-link-check#368.

Ideally the version of the tool should be updated automatically by Renovate bot by creating a pull request on every new release of the tool. This would allow us to control the version used and only ever use a version that actually works.
@andrzej-stencel andrzej-stencel added enhancement New feature or request ci-cd CI, CD, testing, build issues labels Nov 5, 2024
@andrzej-stencel andrzej-stencel mentioned this issue Nov 5, 2024
Merged
@mx-psi mx-psi added the release-retro Issues discussed in a release retrospective label Nov 5, 2024
@andrzej-stencel
Copy link
Member Author

Looks like nothing needs to be changed, Renovate is already doing its job: #11608.

@andrzej-stencel
Copy link
Member Author

andrzej-stencel commented Nov 5, 2024 •
edited
Loading

Not exactly true. It's true that Renovate correctly creates a PR to update markdown-link-check, but the problem is, the check-links job is not run for this PR (see

opentelemetry-collector/.github/workflows/check-links.yaml

Line 34 in 3b7f68d

if: ${{needs.changedfiles.outputs.md}}
). As a result, there is no way to know if the update does not break the tool.

We need to change the check-links job to also be run when the tool is updated - e.g. when package.json file is changed.

@niwoerner niwoerner linked a pull request Nov 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci-cd CI, CD, testing, build issues enhancement New feature or request release-retro Issues discussed in a release retrospective
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chore] Run markdown link check if package.json changes niwoerner/opentelemetry-collector
2 participants
@mx-psi @andrzej-stencel