Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Run markdown link check if package.json changes #11725

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

niwoerner
Copy link

Description

This PR will run the "markdown-link-check" tool if the package.json changes even if no markdown files were updated. This will help to confirm that "markdown-link-check" is still working as expected after a version update/pin.

If 1+ *.md files gets changed AND the package.json gets updated, it will only check the updated files to keep the same behaviour as before.

If only the package.json gets updated it will test all existing *.md files.

Link to tracking issue

Fixes #11606

Testing

I tested/reproduced this manually:

  1. *.md file changes, but package.json not: https://github.com/niwoerner/opentelemetry-collector/actions/runs/11959750938
  2. *.md file and package.json changes: https://github.com/niwoerner/opentelemetry-collector/actions/runs/11959777300
  3. *.md file doesn't change but package.json: https://github.com/niwoerner/opentelemetry-collector/actions/runs/11959797335

@niwoerner niwoerner requested a review from a team as a code owner November 21, 2024 18:59
Copy link

linux-foundation-easycla bot commented Nov 21, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.63%. Comparing base (6ae9c58) to head (11aa90e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11725   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files         442      442           
  Lines       23776    23776           
=======================================
  Hits        21787    21787           
  Misses       1618     1618           
  Partials      371      371           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Renovate for markdown-link-check updates
1 participant