-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[otelcol] Fix grpclogger to capture correct caller location #10773
[otelcol] Fix grpclogger to capture correct caller location #10773
Conversation
Please give a proper title to the PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10773 +/- ##
=======================================
Coverage 91.89% 91.89%
=======================================
Files 411 411
Lines 19318 19318
=======================================
Hits 17752 17752
Misses 1217 1217
Partials 349 349 ☔ View full report in Codecov by Sentry. |
… logger as in grpc
…rsonalstash/opentelemetry-collector into vvs-personalstash-grpclog
Signed-off-by: Yuri Shkuro <[email protected]>
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
@open-telemetry/collector-maintainers can this be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vvs-personalstash
Thanks! |
Description
Cleaned up Grpc logs to make them reference the location where the log statements are written instead of zapgrpc/zapgrpc.go:176
Link to tracking issue
Fixes #10772
Fixes jaegertracing/jaeger#5784