[exporter] [chore] Initialize batchSender and queueSender after configuration - #2 #11184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-sili
changed the title
sfc-gh-sili
commented
Sep 16, 2024
| for _, op := range options { | ||
| err = multierr.Append(err, op(be)) | ||
| } | ||
| } | ||
|
|
||
| // Set up batch sender if batching is enabled |
There was a problem hiding this comment.
Moving batch sender initialization down because in the future we will only initialize batch sender if queue sender is not initialized.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11184 +/- ##
=======================================
Coverage 92.28% 92.29%
=======================================
Files 413 413
Lines 19766 19768 +2
=======================================
+ Hits 18242 18244 +2
Misses 1152 1152
Partials 372 372 ☔ View full report in Codecov by Sentry. |
sfc-gh-sili
force-pushed
the
sili-constructor
branch
from
0b491c6
to
96207f7
Compare
sfc-gh-sili
force-pushed
the
sili-constructor
branch
from
96207f7
to
3461207
Compare
|
Closing Pull request because there has been some changes to |
|
Second trial here: #11240 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows #11041.
The previous PR changed the initialization of
batchSenderandqueueSenderto AFTER configuration, because that enables us to accessqueueConfigandbatcherConfigin the same place.I noticed since then that there is another API for queue configuration, and this PR takes care of that other API
Link to tracking issue
#10368
Testing
Ran
opentelemetry-collector$ maketo make sure all tests still pass.