[cmd/mdatagen]: Add feature gates support to metadata-schema.yaml #11466
+210
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narcis96
force-pushed
the
narcis/feature_gates_in_metadata.yaml_file
branch
from
7514949
to
05ec7bf
Compare
mx-psi
reviewed
Oct 17, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11466 +/- ##
==========================================
- Coverage 91.54% 91.49% -0.06%
==========================================
Files 442 442
Lines 23792 23826 +34
==========================================
+ Hits 21780 21799 +19
- Misses 1641 1654 +13
- Partials 371 373 +2 ☔ View full report in Codecov by Sentry. |
narcis96
force-pushed
the
narcis/feature_gates_in_metadata.yaml_file
branch
4 times, most recently
from
95dc2e8
to
68b465a
Compare
6 tasks
narcis96
force-pushed
the
narcis/feature_gates_in_metadata.yaml_file
branch
2 times, most recently
from
7ffa5a0
to
32f20c5
Compare
mx-psi
reviewed
Oct 22, 2024
narcis96
force-pushed
the
narcis/feature_gates_in_metadata.yaml_file
branch
3 times, most recently
from
b9a675b
to
50d5cf3
Compare
mx-psi
reviewed
Oct 23, 2024
|
Can you fix the merge conflict? The CI won't run otherwise |
narcis96
force-pushed
the
narcis/feature_gates_in_metadata.yaml_file
branch
from
27d1ad9
to
a482d76
Compare
done |
narcis96
force-pushed
the
narcis/feature_gates_in_metadata.yaml_file
branch
3 times, most recently
from
7daa444
to
b63861b
Compare
Co-authored-by: Pablo Baeyens <[email protected]>
narcis96
force-pushed
the
narcis/feature_gates_in_metadata.yaml_file
branch
from
b63861b
to
01e73a2
Compare
|
@mx-psi PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added feature-gates section to metadata-schema.yaml together with id, description, stage and other required. This information can then be used for code generation, documentation generation and by other consumers of the metadata.yaml file
Link to tracking Issue: #9860