Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporterqueue] Default Batcher that reads from the queue, batches and exports #11546

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

sfc-gh-sili
Copy link
Contributor

@sfc-gh-sili sfc-gh-sili commented Oct 28, 2024

Description

This PR follows #11540 and implements support for item-count based batching for queue batcher.

Limitation: This PR supports merging request but not splitting request. In other words, it support specifying a minimum request size but not a maximum request size.

Design doc:
https://docs.google.com/document/d/1y5jt7bQ6HWt04MntF8CjUwMBBeNiJs2gV4uUZfJjAsE/edit?usp=sharing

Link to tracking issue

#8122
#10368

Documentation

@sfc-gh-sili sfc-gh-sili requested a review from a team as a code owner October 28, 2024 00:58
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 97.05882% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.50%. Comparing base (002a748) to head (2f2a6df).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
exporter/internal/queue/default_batcher.go 96.15% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11546      +/-   ##
==========================================
+ Coverage   91.45%   91.50%   +0.04%     
==========================================
  Files         440      441       +1     
  Lines       23887    23984      +97     
==========================================
+ Hits        21846    21946     +100     
+ Misses       1661     1658       -3     
  Partials      380      380              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@songy23 songy23 requested a review from dmitryax October 28, 2024 13:02
@sfc-gh-sili sfc-gh-sili force-pushed the sili-queue-tiny-3 branch 2 times, most recently from 21a6c7c to cc90197 Compare October 29, 2024 21:04
@sfc-gh-sili sfc-gh-sili changed the title [exporterqueue] Supporting [exporterqueue] Default Batcher that reads from the queue, batches and exports Oct 29, 2024
@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 30, 2024
@dmitryax dmitryax merged commit b76b9f7 into open-telemetry:main Oct 30, 2024
65 of 66 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 30, 2024
dmitryax pushed a commit that referenced this pull request Nov 6, 2024
…batcher (#11580)

#### Description

This PR follows
#11546 and
add support for splitting (i.e. support setting a maximum request size)

Design doc:

https://docs.google.com/document/d/1y5jt7bQ6HWt04MntF8CjUwMBBeNiJs2gV4uUZfJjAsE/edit?usp=sharing

#### Link to tracking issue

#8122
#10368
@sfc-gh-sili sfc-gh-sili deleted the sili-queue-tiny-3 branch November 12, 2024 23:20
djaglowski pushed a commit to djaglowski/opentelemetry-collector that referenced this pull request Nov 21, 2024
…d exports (open-telemetry#11546)

#### Description

This PR follows
open-telemetry#11540 and
implements support for item-count based batching for queue batcher.

Limitation: This PR supports merging request but not splitting request.
In other words, it support specifying a minimum request size but not a
maximum request size.

Design doc:

https://docs.google.com/document/d/1y5jt7bQ6HWt04MntF8CjUwMBBeNiJs2gV4uUZfJjAsE/edit?usp=sharing

#### Link to tracking issue

open-telemetry#8122
open-telemetry#10368
djaglowski pushed a commit to djaglowski/opentelemetry-collector that referenced this pull request Nov 21, 2024
…batcher (open-telemetry#11580)

#### Description

This PR follows
open-telemetry#11546 and
add support for splitting (i.e. support setting a maximum request size)

Design doc:

https://docs.google.com/document/d/1y5jt7bQ6HWt04MntF8CjUwMBBeNiJs2gV4uUZfJjAsE/edit?usp=sharing

#### Link to tracking issue

open-telemetry#8122
open-telemetry#10368
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants