Apply default values before we unmarshal the config, allows not using pointers #11596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
usedefault
branch
2 times, most recently
from
1acca23
to
f5743a1
Compare
… pointers Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
usedefault
branch
from
f5743a1
to
586c15d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11596 +/- ##
=======================================
Coverage ? 91.54%
=======================================
Files ? 441
Lines ? 23859
Branches ? 0
=======================================
Hits ? 21841
Misses ? 1645
Partials ? 373 ☔ View full report in Codecov by Sentry. |
dmitryax
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip changelog since this is not visible to our users.