Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update config dependency #11611

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

codeboten
Copy link
Contributor

This PR does a couple of things that I couldn't quite split up so I put together a PR w/ individual commits to help reviewers get through it. This PR does the following:

  1. update go.opentelemetry.io/contrib/config package to latest. this brings in breaking changes. in order to prevent those breaking changes from impacting end users, i've also added a layer of config unmarshaling
  2. updates the collector to instantiate the meter provider (and exporters) via the config package. this allows us to remove all the code in otelinit. the reason for including this change was that unmarshaling the config was causing circular dependencies i didn't want to address by moving code that could be deleted around.

Replacement for #11458.

@codeboten codeboten force-pushed the codeboten/update-config-dependency branch from 390e8a5 to d6ebc54 Compare November 5, 2024 21:18
This change updates the dependency on go.opentelemetry.io/contrib/config to the latest in main. This
is because v0.11.0 has a bug that prevents resource attributes to be applied as labels in the
prometheus exporter. This change contains the following pieces:

1. the update of the dependency
2. add a layer to prevent breaking end users' configuration of exporter headers
3. move the meter provider initialization to depend on the config package
instead of otelinit

Number 3 didn't need to happen in this PR, but doing #2 required a bunch of changes
that can be avoided by moving to using the meter provider from config instead of otelinit.

Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten force-pushed the codeboten/update-config-dependency branch from d6ebc54 to 408f904 Compare November 5, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant