[chore] Small refactoring in builder config validation/parsing

[bogdandrutu]

No description provided.

[codeboten]

This is changing the behaviour or parseModules to not return an updated version of the modules, is that wanted? Or should this be receiving []*Module if we want to change the modules in place?

[bogdandrutu]

Or should this be receiving []*Module if we want to change the modules in place?

Why? The slice is implemented as a pointer to memory and size/cap. The memory can be changed in place, we have tests for that.

[bogdandrutu]

See https://github.com/open-telemetry/opentelemetry-collector/blob/main/cmd/builder/internal/builder/config_test.go#L21

[codecov]

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.59%. Comparing base (9cc15c5) to head (1223c7d).
Report is 59 commits behind head on main.

Files with missing lines	Patch %	Lines
cmd/builder/internal/builder/config.go	96.87%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11613      +/-   ##
==========================================
+ Coverage   91.53%   91.59%   +0.06%     
==========================================
  Files         441      441              
  Lines       23922    23888      -34     
==========================================
- Hits        21896    21880      -16     
+ Misses       1650     1638      -12     
+ Partials      376      370       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 14 days.