system/telemetry metrics OTLP GRPC Exporter: add CA certificate support #11633
+96
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
reviewed
Nov 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11633 +/- ##
=======================================
Coverage ? 91.63%
=======================================
Files ? 442
Lines ? 23781
Branches ? 0
=======================================
Hits ? 21792
Misses ? 1618
Partials ? 371 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
@dmathieu, changelog was added and I fixed the lint issue. Waiting for a review/approval. |
|
Can you run |
@dmathieu, Done. |
dmathieu
approved these changes
Nov 21, 2024
|
Hi @codeboten, it looks like this is blocked on your final review. This is quite a small change; could you take a look when you get a chance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for CA certificates to the OTLP gRPC exporter for metrics in system/telemetry.
Currently if a "Certificate" is specified in the config, it is silently ignored.
Testing
Both a positive and negative unit test was added.
The good test CA certificate was copied from another unit test.
I'm going to file an issue for updating all test certificates as all the ones I checked seem to expire in 2032 which is only 8 years away.
Documentation
None.