[exporter][chore] Exporter queue batcher flushes current batch on shutdown #11666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-sili
changed the title
sfc-gh-sili
force-pushed
the
sili-fix
branch
2 times, most recently
from
e980fb7
to
4ac31e5
Compare
sfc-gh-sili
force-pushed
the
sili-fix
branch
from
4ac31e5
to
3b4541d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11666 +/- ##
==========================================
+ Coverage 91.64% 91.66% +0.01%
==========================================
Files 440 440
Lines 23738 23744 +6
==========================================
+ Hits 21755 21764 +9
+ Misses 1611 1609 -2
+ Partials 372 371 -1 ☔ View full report in Codecov by Sentry. |
dmitryax
approved these changes
Nov 13, 2024
sfc-gh-sili
added a commit
to sfc-gh-sili/opentelemetry-collector
that referenced
this pull request
Nov 13, 2024
…tdown (open-telemetry#11666) This PR changes exporter queue batcher to flush the current batch on shutdown. open-telemetry#10368 open-telemetry#8122
sfc-gh-sili
added a commit
to sfc-gh-sili/opentelemetry-collector
that referenced
this pull request
Nov 13, 2024
…tdown (open-telemetry#11666) This PR changes exporter queue batcher to flush the current batch on shutdown. open-telemetry#10368 open-telemetry#8122
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector
that referenced
this pull request
Nov 21, 2024
…tdown (open-telemetry#11666) #### Description This PR changes exporter queue batcher to flush the current batch on shutdown. #### Link to tracking issue open-telemetry#10368 open-telemetry#8122
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes exporter queue batcher to flush the current batch on shutdown.
Link to tracking issue
#10368
#8122
Testing
exporter/internal/queue/default_batcher_test.goDocumentation