Make pprofile attribute table a real slice

.chloggen/profiles-attributetable-slice.yaml

@@ -0,0 +1,25 @@
+# Use this changelog template to create an entry for release notes.
+
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: breaking
+
+# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
+component: pdata/pprofile
+
+# A brief description of the change.  Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: AttributeTable is now a slice rather than a map
+
+# One or more tracking issues or pull requests related to the change
+issues: [11706]
+
+# (Optional) One or more lines of additional information to render under the primary note.
+# These lines will be padded with 2 spaces and then inserted directly into the document.
+# Use pipe (|) for multiline entries.
+subtext:
+
+# Optional: The change log or logs in which this entry should be included.
+# e.g. '[user]' or '[user, api]'
+# Include 'user' if the change is relevant to end users.
+# Include 'api' if there is a change to a library API.
+# Default: '[user]'
+change_logs: [api]

exporter/debugexporter/internal/otlptext/databuffer.go

@@ -303,7 +303,7 @@ func (b *dataBuffer) logExemplars(description string, se pmetric.ExemplarSlice)
 	}
 }
 
-func (b *dataBuffer) logProfileSamples(ss pprofile.SampleSlice) {
+func (b *dataBuffer) logProfileSamples(ss pprofile.SampleSlice, attrs pprofile.AttributeTableSlice) {
 	if ss.Len() == 0 {
 		return
 	}
@@ -325,7 +325,17 @@ func (b *dataBuffer) logProfileSamples(ss pprofile.SampleSlice) {
 			}
 		}
 		b.logEntry("        Value: %d", sample.Value().AsRaw())
-		b.logEntry("        Attributes: %d", sample.Attributes().AsRaw())
+
+		if lai := sample.Attributes().Len(); lai > 0 {
+			b.logEntry("        Attributes:")
+			for j := 0; j < lai; j++ {
+				if sample.Attributes().At(j) <= math.MaxInt32 {
+					attr := attrs.At(int(sample.Attributes().At(j))) // nolint:gosec // overflow has been checked
+					b.logEntry("             -> %s: %s", attr.Key(), attr.Value().AsRaw())
+				}
+			}
+		}
+
 		b.logEntry("        Link: %d", sample.Link())
 	}
 }

exporter/debugexporter/internal/otlptext/profiles.go

@@ -44,16 +44,11 @@ func (textProfilesMarshaler) MarshalProfiles(pd pprofile.Profiles) ([]byte, erro
 				buf.logEntry("    Drop frames: %d", profile.Profile().DropFrames())
 				buf.logEntry("    Keep frames: %d", profile.Profile().KeepFrames())
 
-				buf.logProfileSamples(profile.Profile().Sample())
+				buf.logProfileSamples(profile.Profile().Sample(), profile.Profile().AttributeTable())
 				buf.logProfileMappings(profile.Profile().Mapping())
 				buf.logProfileLocations(profile.Profile().Location())
 				buf.logProfileFunctions(profile.Profile().Function())
 
-				buf.logAttributesWithIndentation(
-					"Attribute table",
-					profile.Profile().AttributeTable(),
-					4)
-
 				buf.logAttributesWithIndentation(
 					"Attribute units",
 					attributeUnitsToMap(profile.Profile().AttributeUnits()),

exporter/debugexporter/internal/otlptext/profiles_test.go

@@ -72,11 +72,10 @@ func extendProfiles(profiles pprofile.Profiles) pprofile.Profiles {
 			location.SetTypeIndex(5)
 			location.Attributes().FromRaw([]uint64{6, 7})
 
-			_ = profile.Profile().AttributeTable().FromRaw(map[string]any{
-				"value": map[string]any{
-					"intValue": "42",
-				},
-			})
+			at := profile.Profile().AttributeTable()
+			a := at.AppendEmpty()
+			a.SetKey("intValue")
+			a.Value().SetInt(42)
 
 			attributeUnits := profile.Profile().AttributeUnits().AppendEmpty()
 			attributeUnits.SetAttributeKey(1)

exporter/debugexporter/internal/otlptext/testdata/profiles/two_profiles.out

@@ -23,7 +23,8 @@ Profile #0
              -> Num: 3
              -> Num unit: 4
         Value: [4]
-        Attributes: [5]
+        Attributes:
+             -> key: value
         Link: 42
     Location #0
         ID: 2
@@ -36,8 +37,6 @@ Profile #0
         Is folded: true
         Type index: 5
         Attributes: [6 7]
-    Attribute table:
-         -> value: Map({"intValue":"42"})
     Attribute units:
          -> attributeKey: Int(1)
          -> unit: Int(5)
@@ -56,7 +55,8 @@ Profile #1
         Location length: 20
         Stacktrace ID index: 8
         Value: [9]
-        Attributes: [10]
+        Attributes:
+             -> key: value
         Link: 44
     Mapping #0
         ID: 1

pdata/internal/cmd/pdatagen/internal/pprofile_package.go

@@ -46,6 +46,8 @@ var pprofile = &Package{
 		line,
 		functionSlice,
 		function,
+		attributeTableSlice,
+		attribute,
 		attributeUnitSlice,
 		attributeUnit,
 		linkSlice,
@@ -161,7 +163,7 @@ var profile = &messageValueStruct{
 		},
 		&sliceField{
 			fieldName:   "AttributeTable",
-			returnSlice: mapStruct,
+			returnSlice: attributeTableSlice,
 		},
 		&sliceField{
 			fieldName:   "AttributeUnits",
@@ -525,6 +527,29 @@ var line = &messageValueStruct{
 	},
 }
 
+var attributeTableSlice = &sliceOfValues{
+	structName: "AttributeTableSlice",
+	element:    attribute,
+}
+
+var attribute = &messageValueStruct{
+	structName:     "Attribute",
+	description:    "// Attribute describes an attribute stored in a profile's attribute table.",
+	originFullName: "v1.KeyValue",
+	fields: []baseField{
+		&primitiveField{
+			fieldName:  "Key",
+			returnType: "string",
+			defaultVal: `""`,
+			testVal:    `"key"`,
+		},
+		&messageValueField{
+			fieldName:     "Value",
+			returnMessage: anyValue,
+		},
+	},
+}
+
 var functionSlice = &sliceOfPtrs{
 	structName: "FunctionSlice",
 	element:    function,