Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[service] ensure otlp emitted logs respect severity #11718

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[service] ensure otlp emitted logs respect severity #11718

wants to merge 9 commits into from
+29 −3

Conversation

codeboten
Copy link
Contributor

Fixes #11717

@codeboten codeboten requested a review from a team as a code owner November 20, 2024 21:56
codeboten and others added 4 commits November 20, 2024 13:57
@codeboten
Update .chloggen/codeboten_fix-11717.yaml
bb04f0c
@codeboten
[chore] ocb name flag is no longer valid (open-telemetry#11716)
c453255 
This was removed as part of
open-telemetry@cd6bfbb
but the documentation was not updated.

Signed-off-by: Alex Boten <[email protected]>
@renovate @codeboten
chore(deps): update dependency markdown-link-check to v3.13.6 (open-t…
2fe8ec3 
…elemetry#11608)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[markdown-link-check](https://redirect.github.com/tcort/markdown-link-check)
| [`3.12.2` ->
`3.13.6`](https://renovatebot.com/diffs/npm/markdown-link-check/3.12.2/3.13.6)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/markdown-link-check/3.13.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/markdown-link-check/3.13.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/markdown-link-check/3.12.2/3.13.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/markdown-link-check/3.12.2/3.13.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>tcort/markdown-link-check (markdown-link-check)</summary>

###
[`v3.13.6`](https://redirect.github.com/tcort/markdown-link-check/blob/HEAD/CHANGELOG.md#Version-3136)

[Compare
Source](https://redirect.github.com/tcort/markdown-link-check/compare/v3.13.5...v3.13.6)

-   fix: move script back to its original location

###
[`v3.13.5`](https://redirect.github.com/tcort/markdown-link-check/blob/HEAD/CHANGELOG.md#Version-3135)

[Compare
Source](https://redirect.github.com/tcort/markdown-link-check/compare/v3.13.4...v3.13.5)

- fix: MODULE_NOT_FOUND error
[#&open-telemetry#8203;368](https://redirect.github.com/tcort/markdown-link-check/issues/368)

###
[`v3.13.4`](https://redirect.github.com/tcort/markdown-link-check/blob/HEAD/CHANGELOG.md#Version-3134)

[Compare
Source](https://redirect.github.com/tcort/markdown-link-check/compare/v3.13.3...v3.13.4)

- fix: MODULE_NOT_FOUND error
[#&open-telemetry#8203;368](https://redirect.github.com/tcort/markdown-link-check/issues/368)

###
[`v3.13.3`](https://redirect.github.com/tcort/markdown-link-check/blob/HEAD/CHANGELOG.md#Version-3133)

[Compare
Source](https://redirect.github.com/tcort/markdown-link-check/compare/v3.13.2...v3.13.3)

- fix: MODULE_NOT_FOUND error
[#&open-telemetry#8203;368](https://redirect.github.com/tcort/markdown-link-check/issues/368)

###
[`v3.13.2`](https://redirect.github.com/tcort/markdown-link-check/blob/HEAD/CHANGELOG.md#Version-3132)

[Compare
Source](https://redirect.github.com/tcort/markdown-link-check/compare/v3.13.1...v3.13.2)

- fix: MODULE_NOT_FOUND error
[#&open-telemetry#8203;368](https://redirect.github.com/tcort/markdown-link-check/issues/368)

###
[`v3.13.1`](https://redirect.github.com/tcort/markdown-link-check/blob/HEAD/CHANGELOG.md#Version-3131)

[Compare
Source](https://redirect.github.com/tcort/markdown-link-check/compare/v3.13.0...v3.13.1)

- fix: MODULE_NOT_FOUND error
[#&open-telemetry#8203;368](https://redirect.github.com/tcort/markdown-link-check/issues/368)

###
[`v3.13.0`](https://redirect.github.com/tcort/markdown-link-check/blob/HEAD/CHANGELOG.md#Version-3130)

[Compare
Source](https://redirect.github.com/tcort/markdown-link-check/compare/v3.12.2...v3.13.0)

- feat: anchor link checks support HTML tags like `<a name="foo"></a>`
[#&open-telemetry#8203;331](https://redirect.github.com/tcort/markdown-link-check/issues/331)
[@&open-telemetry#8203;dklimpel](https://redirect.github.com/dklimpel)
- ✨ add support for additional test reporters
[#&open-telemetry#8203;364](https://redirect.github.com/tcort/markdown-link-check/issues/364)
[@&open-telemetry#8203;dudeofawesome](https://redirect.github.com/dudeofawesome)
- feat: support iterate link check over directories in CLI
[#&open-telemetry#8203;334](https://redirect.github.com/tcort/markdown-link-check/issues/334)
[@&open-telemetry#8203;dklimpel](https://redirect.github.com/dklimpel)
- Update hook names
[#&open-telemetry#8203;366](https://redirect.github.com/tcort/markdown-link-check/issues/366)
[@&open-telemetry#8203;henrygerardmoore](https://redirect.github.com/henrygerardmoore)
- chore(deps): remove lodash
[#&open-telemetry#8203;332](https://redirect.github.com/tcort/markdown-link-check/issues/332)
[@&open-telemetry#8203;dklimpel](https://redirect.github.com/dklimpel)
- fix: add used `@eslint/js` to dev dependencies in package.json
[#&open-telemetry#8203;330](https://redirect.github.com/tcort/markdown-link-check/issues/330)
[@&open-telemetry#8203;dklimpel](https://redirect.github.com/dklimpel)
- fix: remove not used const url
[#&open-telemetry#8203;329](https://redirect.github.com/tcort/markdown-link-check/issues/329)
[@&open-telemetry#8203;dklimpel](https://redirect.github.com/dklimpel)
- feat: add support for unicode characters in anchor links
[#&open-telemetry#8203;328](https://redirect.github.com/tcort/markdown-link-check/issues/328)
[@&open-telemetry#8203;dklimpel](https://redirect.github.com/dklimpel)
- docs(readme): explain named regex groups in replacementPatterns
[#&open-telemetry#8203;327](https://redirect.github.com/tcort/markdown-link-check/issues/327)
[@&open-telemetry#8203;AndreyNautilus](https://redirect.github.com/AndreyNautilus)
- ci: bump nodejs
[#&open-telemetry#8203;367](https://redirect.github.com/tcort/markdown-link-check/issues/367)
[@&open-telemetry#8203;dklimpel](https://redirect.github.com/dklimpel)
-   update dependencies

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xNDIuNyIsInVwZGF0ZWRJblZlciI6IjM4LjE0Mi43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Alex Boten <[email protected]>
@codeboten
fix test
6a3aefb 
Signed-off-by: Alex Boten <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Nov 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.63%. Comparing base (085db59) to head (eb9e75c).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11718   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files         442      442           
  Lines       23776    23777    +1     
=======================================
+ Hits        21787    21788    +1     
  Misses       1618     1618           
  Partials      371      371

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

TylerHelmuth
TylerHelmuth reviewed Nov 20, 2024
View reviewed changes
cmd/builder/README.md Outdated Show resolved Hide resolved
mx-psi
mx-psi reviewed Nov 21, 2024
View reviewed changes
.chloggen/codeboten_fix-11717.yaml Outdated Show resolved Hide resolved
package.json Outdated
@@ -1,5 +1,5 @@
{
"devDependencies": {
"markdown-link-check": "3.12.2"
"markdown-link-check": "3.13.6"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to rebase/merge main

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right, fixed

service/telemetry/logger.go
@@ -42,12 +42,13 @@ func newLogger(set Settings, cfg Config) (*zap.Logger, log.LoggerProvider, error
lp = set.SDK.LoggerProvider()

logger = logger.WithOptions(zap.WrapCore(func(c zapcore.Core) zapcore.Core {
return zapcore.NewTee(
core, _ := zapcore.NewIncreaseLevelCore(zapcore.NewTee(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we panic when this error is returned? Ignoring the error feels weird. I think we should also add unit tests for every level to check for this error as well

codeboten
codeboten commented Nov 21, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi left review comments

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[service] logs emitted by collector don't follow severity
3 participants
@codeboten @mx-psi @TylerHelmuth