Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter] Feature gate for queue batcher #11721

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[exporter] Feature gate for queue batcher #11721

wants to merge 4 commits into from

Conversation

sfc-gh-sili
Copy link
Contributor

Description

This PR proceeds #11637. It

  • Introduces a noop feature gate that will be used for queue batcher.
  • Updates exporter tests to run with both the feature gate on and off.

Link to tracking issue

#10368
#8122

Testing

Documentation

@sfc-gh-sili sfc-gh-sili requested a review from a team as a code owner November 21, 2024 08:53
@codecov Codecov
Copy link

codecov bot commented Nov 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.63%. Comparing base (085db59) to head (47f7b1a).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11721   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files         442      443    +1     
  Lines       23776    23782    +6     
=======================================
+ Hits        21787    21793    +6     
  Misses       1618     1618           
  Partials      371      371

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 21, 2024
@dmitryax
Copy link
Member

@sfc-gh-sili please run make crosslink

@dmitryax
Copy link
Member

Now make gotidy is needed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

@evan-bradley evan-bradley Awaiting requested review from evan-bradley evan-bradley is a code owner automatically assigned from open-telemetry/collector-approvers

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-sili @dmitryax