Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Refactor obsreport for scrapers to use new scraper.Metrics #11728

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu requested a review from a team as a code owner November 21, 2024 21:44
@bogdandrutu bogdandrutu force-pushed the obsreport_scraper branch 2 times, most recently from ae916e4 to 56fb7a0 Compare November 21, 2024 21:47
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 90.16393% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@00fe41b). Learn more about missing BASE report.
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
receiver/scraperhelper/obs_metrics.go 93.18% 2 Missing and 1 partial ⚠️
receiver/scraperhelper/scrapercontroller.go 81.25% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11728   +/-   ##
=======================================
  Coverage        ?   91.61%           
=======================================
  Files           ?      442           
  Lines           ?    23764           
  Branches        ?        0           
=======================================
  Hits            ?    21772           
  Misses          ?     1620           
  Partials        ?      372           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@bogdandrutu bogdandrutu merged commit 00ad49a into open-telemetry:main Nov 22, 2024
48 of 49 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 22, 2024
@bogdandrutu bogdandrutu deleted the obsreport_scraper branch November 22, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants