Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize walking through frames in a reporter #229

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Nov 8, 2024

Related: #208

@dmathieu
Copy link
Member Author

dmathieu commented Nov 8, 2024

I'm not convinced by this either. It requires passing a lot of context, and this heavy use of any and switch statements really isn't readable.

We can't use generics unless we setup yet another abstraction that would provide us a single interface to set/modify both data types.
Doing this could possibly be a better approach though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant