fix: EBPF_NET_CRASH_METRIC_PORT container env in EBPF chart not being quoted issue. #1347
Conversation
Signed-off-by: Yang, Robin <[email protected]>
Signed-off-by: Yang, Robin <[email protected]>
Signed-off-by: Yang, Robin <[email protected]>
Signed-off-by: Yang, Robin <[email protected]>
Signed-off-by: Yang, Robin <[email protected]>
Signed-off-by: Yang, Robin <[email protected]>
…sue. Signed-off-by: Yang, Robin <[email protected]>
Signed-off-by: Yang, Robin <[email protected]>
|
Hi @nicolastakashi would it be okay if you take a look at this pr when you got chance? |
|
Hi @TylerHelmuth could you take a look this PR ? it's related to containers' env EBPF_NET_CRASH_METRIC_PORT in EBPF chart are not quoted, which will lead eBPF installation failure #1348 |
| @@ -10,4 +10,4 @@ log: | |||
| debug: | |||
| enabled: true | |||
| storeMinidump: true | |||
| sendUnplannedExitMetric: false | |||
There was a problem hiding this comment.
Should we revert it?
There was a problem hiding this comment.
@hyfj44255 I was wondering if it should be another ci testing, since this one is related to debug logs.
Wdyt?
There was a problem hiding this comment.
Thanks @nicolastakashi let me revert it and create another -values.yaml file for testing it
|
@hyfj44255 minor comment, besides that LGTM |
Hi@nicolastakashi thank you so much for your reivew, IMHO, we might want to set it to true since we can test out whether containers' env EBPF_NET_CRASHL_METRIC_PORT has been quoted |
kayhern
force-pushed
the
ebfp-container-env-quote
branch
from
9ad2e5f
to
696c7a1
Compare
|
Hi @nicolastakashi I added a other *-values.yaml file to test containers env quote issue , I was wondering if you could take a look charts/opentelemetry-ebpf/ci/send-unplanned-exit-metric-values.yaml |
|
@TylerHelmuth can you help us merging this, if it's looking good for you? |
Description
Currently the containers' EBPF_NET_CRASH_METRIC_PORT env in EBPF chart are not quoted, which will lead EBPF installation failure
Fixes # (issue)
#1348
Type of change
How Has This Been Tested?
Go to repo root directory.
cd opentelemetry-helm-chartsCreate a kind cluster same as the one in repo's Github action
kind create cluster --name ebpf-cluster --config ./.github/kind-1.24.yamlRun CT to preform the test
ct install --charts charts/opentelemetry-ebpf.