Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(collector): actually enable the deployment of PrometheusRule when using PodMonitor #1416

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(collector): actually enable the deployment of PrometheusRule when using PodMonitor #1416

wants to merge 4 commits into from

Commits on Nov 15, 2024

  1. fix(collector): introduce or conditional to enable the deployment of … 

    …PodMonitor

PodMonitor was not being deployed because this logic was not in place.

open-telemetry#1379
    @crutonjohn
    crutonjohn committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    d66946d View commit details
    Browse the repository at this point in the history

  2. chore(collector): bumping chart minor version

    @crutonjohn
    crutonjohn committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    a73d0f8 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2024

  1. fix(collector): only render PrometheusRule when ServiceMonitor is dep… 

    …loyed

this fixes a regression introduced by myself in my last commit

open-telemetry#1379
    @crutonjohn
    crutonjohn committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    d2d253a View commit details
    Browse the repository at this point in the history

  2. fix(collector): prometheusRule should render when specified 

    this fixes a regression i introduced related to rendering the PrometheusRule conditions. it should
now render in a wide array of scenarios.

open-telemetry#1379
    @crutonjohn
    crutonjohn committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    ba5fd56 View commit details
    Browse the repository at this point in the history