add warning log for extension #11634
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasKunz
reviewed
Jun 25, 2024
javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/ExtensionClassLoader.java
Outdated
Show resolved
Hide resolved
heyams
reviewed
Aug 28, 2024
| if (externalExtensionsLocation != null && !externalExtensionsLocation.isEmpty()) { | ||
| List<URL> externalExtensions = parseLocation(externalExtensionsLocation, javaagentFile); | ||
| if (externalExtensions.isEmpty()) { | ||
| extensionClassLoadWarningMessage = |
There was a problem hiding this comment.
when extensionClassLoadWarningMessage is generated here, can you simply log it right after?
i don't find it necessary to have another static method logWarningIfAny and call it in AgentStarterImpl.
unless it's too early because of loggingCustomizer.init(earlyConfig)?
There was a problem hiding this comment.
see the comment above
// this class is used early, and must not use logging in most of its methods
// in case the extension config can not be found, we save the warning
// message and log it later, when the logging subsystem is initialized
trask
reviewed
Aug 28, 2024
| if (externalExtensionsLocation != null && !externalExtensionsLocation.isEmpty()) { | ||
| List<URL> externalExtensions = parseLocation(externalExtensionsLocation, javaagentFile); | ||
| if (externalExtensions.isEmpty()) { | ||
| extensionClassLoadWarningMessage = |
There was a problem hiding this comment.
see the comment above
// this class is used early, and must not use logging in most of its methods
// in case the extension config can not be found, we save the warning
// message and log it later, when the logging subsystem is initialized
| String externalExtensionsLocation = earlyConfig.getString(EXTENSIONS_CONFIG); | ||
| if (externalExtensionsLocation != null && !externalExtensionsLocation.isEmpty()) { | ||
| List<URL> externalExtensions = parseLocation(externalExtensionsLocation, javaagentFile); | ||
| if (externalExtensions.isEmpty()) { |
There was a problem hiding this comment.
might be nice to log warning when there are multiple extensions, but one of them is invalid location?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #11616